Hold actions on the back of decisions, rather than process them, if content is high profile #22766
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: mozilla/addons#15074
Description
This patch changes decision handling from Cinder, to check if the decision/content is high profile, and if so to not carry out the action - just log the action that should have happened.
Context
This is the first part of larger epic - further work will expose the held actions and allow them to be carried out (or not). No decisions are coming from Cinder at this time so we're pretty safe to land it half finished ... though it could be argued it should be behind a waffle switch 🤷
Testing
Bit of a pain to test fully, because it relies on having your cinder auth enabled for the report, and manually applying webhook payloads. But roughly:
@permission_classes((CinderInboundPermission,))
!)Checklist
#ISSUENUM
at the top of your PR to an existing open issue in the mozilla/addons repository.