Follow up for "Migrate from BlockVersion.soft to BlockVersion.block_type" #22821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bakulf
force-pushed
the
positiveTinyInteger
branch
from
e68100d to
ee25d84
Compare
bakulf
force-pushed
the
positiveTinyInteger2
branch
from
9f2229a to
e170cae
Compare
bakulf
force-pushed
the
positiveTinyInteger
branch
from
ee25d84 to
1d89978
Compare
bakulf
force-pushed
the
positiveTinyInteger2
branch
from
e170cae to
3e43152
Compare
bakulf
force-pushed
the
positiveTinyInteger2
branch
from
3e43152 to
da8eb68
Compare
This appears to be fixed already. Either the other PR shouldn't have closed as fixed the issue, or another issue is needed :) |
KevinMind
reviewed
Nov 8, 2024
src/olympia/blocklist/migrations/0038_remove_blockversion_soft.py
Outdated
Show resolved
Hide resolved
bakulf
force-pushed
the
positiveTinyInteger2
branch
from
da8eb68 to
d212b9f
Compare
KevinMind
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
I did not verify this locally but it looks good to me code wise. The migration will run on dev and stage before prod so that might be testing enough.
Probably not a terrible idea to verify locally by
- create a BlockVersion with block_type==None and soft==true/false
- run the migration
- expect it passes and the value is updated correctly.
The former. The issue should still be open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: mozilla/addons/issues/15111
Description
This PR is the follow up for #22811. It does the following:
Context
See #22811.
Testing
No new tests needed.
Checklist
#ISSUENUMat the top of your PR to an existing open issue in the mozilla/addons repository.