-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove race conditions in docker volumes during build/runtime #22912
Conversation
3148d5c
to
0b7a3a7
Compare
1befc19
to
1525885
Compare
@diox there is a hypotehtical even more stop gap solution that would remove the named Edit: Split to 3 commits:
|
1b7905e
to
b8f67ae
Compare
d8b2979
to
d756e11
Compare
- Renamed 'worker' service to 'olympia' in docker-compose.ci.yml and docker-compose.yml for clarity. - Introduced a new 'olympia' service with a persistent volume for site static files. - Updated 'worker' service to extend from 'olympia' and adjusted volume mappings accordingly. - Added dependency for 'nginx' service on 'olympia' to ensure proper startup order. - Changed base image for pip development stage in Dockerfile to improve build consistency. This commit enhances the organization of Docker services and improves the overall structure of the Docker setup.
bea3ef1
to
6a1cea9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is the stopgap, can we reference the ideal solution somewhere ? Maybe in the Dockerfile
next to the line you're changing ?
It's a moving target so I'll hold off on that. |
* Prevent race conditions in docker volume mounts - Renamed 'worker' service to 'olympia' in docker-compose.ci.yml and docker-compose.yml for clarity. - Introduced a new 'olympia' service with a persistent volume for site static files. - Updated 'worker' service to extend from 'olympia' and adjusted volume mappings accordingly. - Added dependency for 'nginx' service on 'olympia' to ensure proper startup order. - Changed base image for pip development stage in Dockerfile to improve build consistency. This commit enhances the organization of Docker services and improves the overall structure of the Docker setup.
Fixes: mozilla/addons#15046
Description
Context
It is not feasible to test a race condition like this, so instead the configuration and runtime checks are setup in a way to virtually guarantee:
This comes here where tests are currently failing due to missing this patch.
Testing
There isn't really a good way to test this PR outside of adding the commit from the other patch, and then running the
test_setup
tests to verify statically the configuration is valid.Checklist
#ISSUENUM
at the top of your PR to an existing open issue in the mozilla/addons repository.