-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Django 1.11 (latest LTS) #4292
Comments
Leaving assigned for this week but I'm pausing work on this because I'm kinda stuck. Translations are half-broken because of a change in django that cause Also broken are all widgets that need custom rendering, those were using private APIs that have changed with the introduction of template-based widgets rendering. This is more straightforward to fix, just tedious. |
Random note I just discovered: https://docs.djangoproject.com/en/1.11/ref/settings/#std:setting-CSRF_USE_SESSIONS, which is new in 1.11, allows us to remove |
Note on that, I started doing that in the django 1.11 branch but https://github.com/mozilla/django-session-csrf/blob/master/session_csrf/__init__.py#L144-L171 needs to be reimplemented to some degree as far as I can tell. still investigating, didn't look into that too deeply for now. |
Please see https://bugzilla.mozilla.org/show_bug.cgi?id=1434466 about a security issue in Django v1.11. CC'd you there as well. |
I'm unassigning myself from this for now, I won't have time to work on this during the next two weeks I think. I'll re-assign this once I manage to get to it again. |
Started working on this again, full speed ahead towards Django 1.11! |
Clearing milestone for now to avoid moving this every week again and again. |
QA: Marking this as So, please make sure, that:
Please let me know if you have any questions about that. Thanks a lot! This is currently on -dev and will head to -stage next Tuesday targeting a deployment next Thursday (2018.07.19) |
After another round of testing on Stage, no new issues were found. Marking bug as verified. |
(most notably Move zh-tw and zh-cn locales to zh-hant and zh-hans, respectively #4515)The text was updated successfully, but these errors were encountered: