Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add-on icon can't be changed from DevHub Edit information page #5798

Closed
AlexandraMoga opened this issue Jul 17, 2018 · 6 comments · Fixed by mozilla/addons-server#8930 or mozilla/addons-server#8971
Closed

Add-on icon can't be changed from DevHub Edit information page #5798

AlexandraMoga opened this issue Jul 17, 2018 · 6 comments · Fixed by mozilla/addons-server#8930 or mozilla/addons-server#8971
Assignees
@EnTeQuAk
Labels
component:developer_hub repository:addons-server Issue relating to addons-server state:verified_fixed
Milestone
2018.07.26

Comments

@AlexandraMoga
Copy link

AlexandraMoga commented Jul 17, 2018 •
edited
Loading

STR:

  1. Log in to Developer Hub
  2. Navigate to Manage my submissions and choose one of your add-ons to edit
  3. Change the add-on icon to one of the predefined options or upload a custom icon
  4. Save changes

Actual result:
The default add-on icon is still displayed after the changes have been saved

Expected result:
The updated icon (predefined or custom) should be displayed after the changes have been saved

Notes:

icon not set
@EnTeQuAk
Copy link
Contributor

This sounds like a Django 1.11 regression.

I can take a look at this.

@EnTeQuAk EnTeQuAk self-assigned this Jul 17, 2018
@EnTeQuAk EnTeQuAk added this to the 2018.07.19 milestone Jul 19, 2018
@EnTeQuAk
Copy link
Contributor

Yeah, this happened when I re-implemented the IconTypeSelect widget and I missed the label/input fields which leads to nothing being saved.

EnTeQuAk referenced this issue in mozilla/addons-server Jul 19, 2018
@EnTeQuAk
Correctly render label and input fields.
82c7d1c 
Somehow they got lost along the way when I refactored the IconTypeSelect
widget.

Fixes #8900
@EnTeQuAk EnTeQuAk mentioned this issue Jul 19, 2018
Merged
EnTeQuAk referenced this issue in mozilla/addons-server Jul 19, 2018
@EnTeQuAk
Correctly render label and input fields. (#8930)
0e0f592 
* Correctly render label and input fields.

Somehow they got lost along the way when I refactored the IconTypeSelect
widget.

Fixes #8900

* Fix typo
@AlexandraMoga
Copy link
Author

@EnTeQuAk sadly I can still reproduce the issue for the case when a custom icon is uploaded. I'm inclined to re-open the issue...

@AlexandraMoga AlexandraMoga reopened this Jul 19, 2018
@eviljeff eviljeff modified the milestones: 2018.07.19, 2018.07.26 Jul 19, 2018
@EnTeQuAk
Copy link
Contributor

I'll look into that.

@EnTeQuAk EnTeQuAk mentioned this issue Jul 24, 2018
Merged
EnTeQuAk referenced this issue in mozilla/addons-server Jul 24, 2018
@EnTeQuAk
Fix rendering of input fields for custom icon upload.
3b5c776 
Fixes #8900
@AlexandraMoga
Copy link
Author

Verified on AMO -dev with FF61, Win10x64

Custom add-on icons can now be uploaded from DevHub:

custom icon

I can see that there is another issue here at icon preview rendering: the 64x64 preview is generated but the 32x32 is displayed only after the page is refreshed. Since this is only a small issue, I will file a bug to track it separately.

@EnTeQuAk
Copy link
Contributor

EnTeQuAk commented Jul 24, 2018 via email

@KevinMind KevinMind added migration:no-jira repository:addons-server Issue relating to addons-server labels May 4, 2024
@KevinMind KevinMind transferred this issue from mozilla/addons-server May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EnTeQuAk EnTeQuAk

Labels
component:developer_hub repository:addons-server Issue relating to addons-server state:verified_fixed
Projects
None yet
Milestone
2018.07.26
4 participants
@EnTeQuAk @eviljeff @KevinMind @AlexandraMoga