bug: Fix auth header for push #1080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* include auth type prefix * fix URL for channel list (note: mozilla-services/autopush#1330 Closes #1079
thomcc
approved these changes
Apr 25, 2019
| return Err(CommunicationError(format!( | ||
| "Unhandled client error {} : {:?}", | ||
| requested.status, | ||
| String::from_utf8_lossy(&requested.body) |
There was a problem hiding this comment.
Hmm, is there any risk of PII in the body?
There was a problem hiding this comment.
Quite the opposite. Our push servers return extended help info whenever they hit an error. This info was getting lost in how the message was being returned.
| } | ||
| if self.auth.is_none() { | ||
| self.auth = response["secret"].as_str().map(ToString::to_string); | ||
| println!("### Got Auth {:?}", self.auth); |
There was a problem hiding this comment.
Nit: get rid of the println before landing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
db Message.all_channels() does not use properly formed uaid mozilla-services/autopush#1330
Closes #1079
Pull Request checklist
cargo test --allproduces no test failurescargo clippy --all --all-targets --all-featuresruns without emitting any warningscargo fmtdoes not produce any changes to the code./gradlew ktlint detektruns without emitting any warnings[ci full]to the PR title.