-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POC protobuf communication over FFI #626
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot on this! This looks pretty cool.
I'd like doc comments on the ffi_support changes. Also, could you do a version bump on it when you're done?
I also think we should look into Prost, since the set_blah boilerplate is a bit of step backwards IMO. It seems pretty actively maintained, actually.
Also, the Int/Long distinction is a big issue too.
components/fxa-client/android/src/main/java/org/mozilla/fxaclient/internal/ProtoWrapper.kt
Outdated
Show resolved
Hide resolved
35fa958
to
041f0b7
Compare
Mind having a look again?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for your work on this, and I'm sorry that I have so many review comments.
I'd like to see it again, though, one last time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some comments, seems to work locally, built with Android Studio locally
components/fxa-client/android/src/main/java/org/mozilla/fxaclient/internal/ByteBuffer.kt
Show resolved
Hide resolved
components/fxa-client/android/src/main/java/org/mozilla/fxaclient/internal/Profile.kt
Show resolved
Hide resolved
2a669b3
to
e8a82eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good, if you can do the convert_protobuf_to_byte_buffer inside the macro i'd prefer that, but if not it's fine.
See #612 for discussion.