Update remote settings errors #6408
Conversation
|
|
||
| impl SettingsClient for Client { | ||
| impl SettingsClient for RemoteSettings { |
There was a problem hiding this comment.
These nimbus changes seem pretty harmless, but please double-check my work here.
| /// Internal version of `url()`. | ||
| /// | ||
| /// The difference is that it uses `Error` instead of `ApiError`. This is what we need to use | ||
| /// inside the crate. |
There was a problem hiding this comment.
This is one annoying part about splitting up the errors into internal vs external errors. url() needs to return an ApiResult since it's pub and used by consumers (nimbus), but then Client::new can't use it since it returns a Result<> type.
I've thought about solutions for this for a while, but hasn't been annoying enough to take any action.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6408 +/- ##
===========================================
- Coverage 49.30% 25.49% -23.82%
===========================================
Files 146 284 +138
Lines 13708 26515 +12807
===========================================
Hits 6759 6759
- Misses 6949 19756 +12807 ☔ View full report in Codecov by Sentry. |
bendk
force-pushed
the
push-nlwmntwttruv
branch
2 times, most recently
from
1e19535
to
34f164c
Compare
Use fields inside the error enum, rather than the UniFFI "flat" errors which ignore the inner data. This is prep for moving to proc-macros. Switched to using error_support and define both internal and public error types. Switch app-services consumers to using the `RemoteSettings` type rather than `Client`. This way they're using the same public API as everyone else. This required adding a couple more pub RemoteSettings methods that I didn't expose via UniFFI. I didn't feel like adding new features to this client, because I'm hoping to replace it (mozilla#6378).
bendk
force-pushed
the
push-nlwmntwttruv
branch
from
34f164c
to
815b4e2
Compare
Use fields inside the error enum, rather than the UniFFI "flat" errors which ignore the inner data. This is prep for moving to proc-macros.
Switched to using error_support and define both internal and public error types.
Switch app-services consumers to using the
RemoteSettingstype rather thanClient. This way they're using the same public API as everyone else. This required adding a couple more pub RemoteSettings methods that I didn't expose via UniFFI. I didn't feel like adding new features to this client, because I'm hoping to replace it (#6378).Pull Request checklist
[ci full]to the PR title.Branch builds: add
[firefox-android: branch-name]to the PR title.