Add country to weather suggestions
#6419
Open
+52
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I just saw that Merino expects a country to be passed along with city and region in weather requests. Rather than assuming "US" and hardcoding that in desktop, which would be fine for now, let's just go ahead and add the matching geoname's country code to `Suggestion::Weather`. It's a small change. This doesn't modify query parsing at all. Country names still aren't supported in queries. We can cross that bridge if/when we come to it.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6419 +/- ##
=======================================
Coverage 21.99% 21.99%
=======================================
Files 342 342
Lines 30729 30729
=======================================
Hits 6759 6759
Misses 23970 23970 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just saw that Merino expects a country to be passed along with city and region in weather requests. Rather than assuming "US" and hardcoding that in desktop, which would be fine for now, let's just go ahead and add the matching geoname's country code to
Suggestion::Weather. It's a small change.This doesn't modify query parsing at all. Country names still aren't supported in queries. We can cross that bridge if/when we come to it.
Pull Request checklist
[ci full]to the PR title.Branch builds: add
[firefox-android: branch-name]to the PR title.