Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

define and implement function to get calculated nimbus context attributes #6493

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

jeddai
Copy link
Member

@jeddai jeddai commented Nov 25, 2024

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

Branch builds: add [firefox-android: branch-name] to the PR title.

@jeddai jeddai added the O(n) Well-scoped logic changes label Nov 25, 2024
@jeddai jeddai requested a review from brennie November 25, 2024 14:41
@jeddai jeddai self-assigned this Nov 25, 2024
@jeddai jeddai force-pushed the context-calculations-function branch from b47eb5b to 09ae175 Compare November 25, 2024 15:07
@jeddai jeddai enabled auto-merge November 25, 2024 15:07
@jeddai jeddai added this pull request to the merge queue Nov 25, 2024
Merged via the queue into mozilla:main with commit 449ae15 Nov 25, 2024
15 checks passed
@jeddai jeddai deleted the context-calculations-function branch November 25, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O(n) Well-scoped logic changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants