Update footer newsletter text and signups (fixes #15585) #15703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maureenlholland
force-pushed
the
update-footer-newsletters
branch
4 times, most recently
from
c266e08 to
62f29b6
Compare
maureenlholland
commented
Dec 10, 2024
maureenlholland
commented
Dec 10, 2024
Removes initial newsletter string, it cannot be used as a fallback because the new newsletter sign-up includes more than just Firefox content.
maureenlholland
force-pushed
the
update-footer-newsletters
branch
from
62f29b6 to
3a5da15
Compare
maureenlholland
commented
Dec 10, 2024
maureenlholland
added
Needs Review
wen-2018
approved these changes
Dec 11, 2024
|
r+ 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One-line summary
Update footer newsletter signup to include foundation newsletter as well
mozilla-and-you and mozilla-foundation
Significant changes and points to review
Footer newsletter now has two newsletter sign up options
Couple of styling challenges that should be fixed now (and have hopefully not created new issues)
general spacing
large font
Issue / Bugzilla link
#15585
Testing
Go to http://localhost:8000/en-US/ and confirm the newsletter expands with 2 newletters checked: firefox & mozilla foundations
Uncheck both newsletters and confirm you cannot sign up without selecting at least one
Check newsletters and confirm you get thanks message and network tab shows request with expected newsletters
