Fix footer donate visited color #15722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One-line summary
Avoids using "visited" purple color for Donate CTA in footer of fx base pages.
Significant changes and points to review
The color was only set on anchor, not :link — and in m24 base styles the :link generally defines white color — something not present in fx styles, where the visited purple treatment is then applied to this CTA.
Moving the CTA color from anchor to :link/:visited is the easiest fix. I don't see anything that can be negatively impacted by missing the white color on the anchor proper, and just defining it for the pseudos, but felt it's worth noting nonetheless.
Issue / Bugzilla link
Fixes #15701
Testing
http://localhost:8000/en-US/firefox/133.0/whatsnew/#colophon
http://localhost:8000/en-US/firefox/welcome/10/#colophon
(Click the Donate button in the footer so it's marked as visited.)