Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support wagtail-localize-smartling 0.10 #15830

Merged

Conversation

stevejalim
Copy link
Collaborator

@stevejalim stevejalim commented Jan 9, 2025

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.22%. Comparing base (bb3f3a8) to head (35d6597).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
bedrock/settings/base.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15830      +/-   ##
==========================================
+ Coverage   79.10%   79.22%   +0.11%     
==========================================
  Files         160      159       -1     
  Lines        8312     8287      -25     
==========================================
- Hits         6575     6565      -10     
+ Misses       1737     1722      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This has been moved to wagtail-localize-smartling 0.10.0
It needs django.contrib.humanize to be in INSTALLED_APPS, in order to
support markup for the task dashboard added to w-l-s
@stevejalim stevejalim force-pushed the 15348-wls-44--add-landed-translation-list-to-dashboard branch from 46b5966 to 35d6597 Compare January 10, 2025 14:09
@stevejalim stevejalim changed the title Draft: support wagtail-localize-smartling 0.10.0 Support wagtail-localize-smartling 0.10 Jan 10, 2025
@stevejalim stevejalim marked this pull request as ready for review January 10, 2025 14:23
@stevejalim stevejalim requested a review from a team as a code owner January 10, 2025 14:23
Copy link
Member

@alexgibson alexgibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

@stevejalim stevejalim merged commit ad2aa5e into main Jan 10, 2025
5 checks passed
@stevejalim stevejalim deleted the 15348-wls-44--add-landed-translation-list-to-dashboard branch January 10, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants