Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @mozmeao/consent-banner to v1.1.0 (Fixes #15839) #15842

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

alexgibson
Copy link
Member

@alexgibson alexgibson commented Jan 10, 2025

One-line summary

Bumps consent banner to the latest version. The only notable change is that the font stack was updated to incorporate the new Mozilla brand font (see mozmeao/consent-banner#67)

Issue / Bugzilla link

#15839

Testing

Test in a browser with DNT / GPC disabled:

http://localhost:8000/en-US/products/vpn/?geo=de

  • Consent banner should display using the new brand font and not Inter.

@alexgibson alexgibson added P3 Third level priority - Nice to have Needs Review Awaiting code review Review: µ Code review time: 5 minutes or less labels Jan 10, 2025
@alexgibson alexgibson requested a review from a team as a code owner January 10, 2025 14:17
@wen-2018 wen-2018 self-assigned this Jan 10, 2025
@wen-2018 wen-2018 removed the Needs Review Awaiting code review label Jan 10, 2025
Copy link
Collaborator

@wen-2018 wen-2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ 🦊

@wen-2018 wen-2018 merged commit a092ffc into mozilla:main Jan 10, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Third level priority - Nice to have Review: µ Code review time: 5 minutes or less
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants