Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UK influencer campaign page (Fixes #15841) #15858

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

alexgibson
Copy link
Member

@alexgibson alexgibson commented Jan 14, 2025

One-line summary

  • Adds a UK influencer campaign landing page at /firefox/landing/tech/.

Significant changes and points to review

  • Page is identical to /firefox/new/ except:
    • It serves a custom Firefox build for both Windows and macOS users (links updated via JS).
    • Download buttons trigger direct downloads (not through the /thanks/ page).
    • Page is /en-GB/ only.
    • Page contains a noindex meta tag.

Issue / Bugzilla link

#15841

Testing

http://localhost:8000/en-GB/firefox/landing/tech/

  • MacOS desktop download buttons should download custom build (partner-firefox-release-smi-smi-001-latest)
  • Windows desktop download buttons should download partner-firefox-release-smi-smi-001-stub.
  • Download buttons trigger direct downloads (not through the /thanks/ page).
  • Page is /en-GB/ only.
  • Page contains a noindex meta tag.

@alexgibson alexgibson added the P2 Second level priority - Should have label Jan 14, 2025
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.29%. Comparing base (eefdbfa) to head (d5f9034).
Report is 14 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15858   +/-   ##
=======================================
  Coverage   79.28%   79.29%           
=======================================
  Files         159      159           
  Lines        8343     8347    +4     
=======================================
+ Hits         6615     6619    +4     
  Misses       1728     1728           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexgibson alexgibson force-pushed the uk-influencer branch 3 times, most recently from 954d255 to 74df851 Compare January 17, 2025 10:27
@alexgibson alexgibson force-pushed the uk-influencer branch 5 times, most recently from 114542d to f90d8bf Compare January 23, 2025 13:06
@alexgibson alexgibson added P1 First level priority - Must have Needs Review Awaiting code review Review: XS Code review time: up to 30min and removed P2 Second level priority - Should have labels Jan 23, 2025
@alexgibson
Copy link
Member Author

alexgibson commented Jan 24, 2025

Production bouncer links are now live, so this should be code complete. Just waiting on legal to give final sign off.

@alexgibson alexgibson marked this pull request as ready for review January 24, 2025 16:39
@alexgibson alexgibson requested review from a team as code owners January 24, 2025 16:39
@stephaniehobson stephaniehobson self-assigned this Jan 24, 2025
@stephaniehobson
Copy link
Contributor

stephaniehobson commented Jan 24, 2025

Note to self: I need to look and see what GA4 does with this. IIRC it uses the URL to tell the release channels apart.

Copy link
Contributor

@stephaniehobson stephaniehobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some one letter/word tweaks for legibility, NBD.

And a question... how do we want these tracked in GA4? At the moment they are not triggering a firefox_download and are passing some weird params to product_download because the script expects values in the download URL.

bedrock/firefox/templates/firefox/landing/tech.html Outdated Show resolved Hide resolved
tests/unit/spec/firefox/landing/partner-build-download.js Outdated Show resolved Hide resolved
tests/unit/spec/firefox/landing/partner-build-download.js Outdated Show resolved Hide resolved
tests/unit/spec/firefox/landing/partner-build-download.js Outdated Show resolved Hide resolved
tests/unit/spec/firefox/landing/partner-build-download.js Outdated Show resolved Hide resolved
tests/unit/spec/firefox/landing/partner-build-download.js Outdated Show resolved Hide resolved
@alexgibson
Copy link
Member Author

And a question... how do we want these tracked in GA4? At the moment they are not triggering a firefox_download and are passing some weird params to product_download because the script expects values in the download URL.

Good catch. - I think we can consider partner distribution builds like regular release channel Firefox downloads. They are only triggered from specific pages, so I don't think there's any need to create a new download event category for them. I'll add some logic so they trigger a regular firefox_download event.

@alexgibson
Copy link
Member Author

@stephaniehobson thanks for the review, updated

@alexgibson alexgibson removed the Needs Review Awaiting code review label Jan 27, 2025
Copy link
Collaborator

@maureenlholland maureenlholland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ 🎉 fix commit looks good to me

@alexgibson alexgibson merged commit 215a951 into mozilla:main Jan 27, 2025
5 checks passed
@alexgibson alexgibson deleted the uk-influencer branch January 27, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 First level priority - Must have Review: XS Code review time: up to 30min
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants