-
Notifications
You must be signed in to change notification settings - Fork 927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UK influencer campaign page (Fixes #15841) #15858
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15858 +/- ##
=======================================
Coverage 79.28% 79.29%
=======================================
Files 159 159
Lines 8343 8347 +4
=======================================
+ Hits 6615 6619 +4
Misses 1728 1728 ☔ View full report in Codecov by Sentry. |
954d255
to
74df851
Compare
114542d
to
f90d8bf
Compare
f90d8bf
to
d005ccd
Compare
d005ccd
to
6e138c7
Compare
Production bouncer links are now live, so this should be code complete. Just waiting on legal to give final sign off. |
Note to self: I need to look and see what GA4 does with this. IIRC it uses the URL to tell the release channels apart. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some one letter/word tweaks for legibility, NBD.
And a question... how do we want these tracked in GA4? At the moment they are not triggering a firefox_download
and are passing some weird params to product_download
because the script expects values in the download URL.
Good catch. - I think we can consider partner distribution builds like regular release channel Firefox downloads. They are only triggered from specific pages, so I don't think there's any need to create a new download event category for them. I'll add some logic so they trigger a regular |
@stephaniehobson thanks for the review, updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r+ 🎉 fix commit looks good to me
One-line summary
/firefox/landing/tech/
.Significant changes and points to review
/firefox/new/
except:/thanks/
page)./en-GB/
only.noindex
meta tag.Issue / Bugzilla link
#15841
Testing
http://localhost:8000/en-GB/firefox/landing/tech/
partner-firefox-release-smi-smi-001-latest
)partner-firefox-release-smi-smi-001-stub
./thanks/
page)./en-GB/
only.noindex
meta tag.