Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MDN nav icon #15865

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update MDN nav icon #15865

wants to merge 3 commits into from

Conversation

janbrasna
Copy link
Contributor

@janbrasna janbrasna commented Jan 14, 2025

One-line summary

Uses MDN logo asset instead, as referenced from other parts of the site.

Significant changes and points to review

Cleans up unused icons from long gone pages.
(Also renames some icons for consistency.)

Issue / Bugzilla link

Resolves #15864

Testing

http://localhost:8000/
(also with ./manage.py waffle_switch M24_WEBSITE_REFRESH off for og nav used by outdated locales)
http://localhost:8000/firefox/welcome/4/
http://localhost:8000/newsletter/updated/

@janbrasna janbrasna requested a review from a team as a code owner January 14, 2025 17:28
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.28%. Comparing base (9db97b8) to head (da15d11).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15865      +/-   ##
==========================================
+ Coverage   79.22%   79.28%   +0.06%     
==========================================
  Files         159      159              
  Lines        8287     8343      +56     
==========================================
+ Hits         6565     6615      +50     
- Misses       1722     1728       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MDN Plus logo in nav not the correct shade
1 participant