Bug 1697602 Remove derived tables for AET #1894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jklukas
commented
Mar 15, 2021
| ECOSYSTEM_CLIENT_ID_SRC = DeleteSource( | ||
| table="account_ecosystem_restricted.ecosystem_client_id_deletion_v1", | ||
| field=ECOSYSTEM_CLIENT_ID, | ||
| ) |
There was a problem hiding this comment.
We are now dropping any remaining AET messages in the pipeline, so we will not be accruing any new entries in the stable tables, and there should be no further need for processing ecosystem_client_id as part of deletion requests.
jklukas
commented
Mar 15, 2021
| @@ -369,9 +341,6 @@ def fields(self) -> Tuple[str, ...]: | |||
| client_id_target(table="eng_workflow_stable.build_v1"), | |||
| # other | |||
| DeleteTarget(table="telemetry_stable.pioneer_study_v4", field=PIONEER_ID), | |||
| DeleteTarget( | |||
| table="telemetry_stable.pre_account_v4", field=DESKTOP_ECOSYSTEM_CLIENT_ID | |||
| ), | |||
There was a problem hiding this comment.
I believe pre_account was added here in error. It does indeed have a field called ecosystem_client_id, but it is always set to "unknown". The pre-account ping was associated with a previous incarnation of "ecosystem telemetry" rather than AET.
relud
approved these changes
Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of overall work for https://bugzilla.mozilla.org/show_bug.cgi?id=1697602
We will need to remove the underlying tables once this is merged.