Bug 1732293 More processing of namespace and doctype #2388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jklukas
commented
Sep 29, 2021
| @@ -64,7 +64,8 @@ | |||
| submission_date | |||
| """ | |||
|
|
|||
| EXCLUDED_NAMESPACES = {"xfocsp_error_report"} # restricted access | |||
| # Restricted access | |||
| EXCLUDED_NAMESPACES = {"regrets_reporter", "contextual_services"} | |||
There was a problem hiding this comment.
I did local testing this time to make sure all the remaining issues were worked out. Because my personal account doesn't have access to these two namespaces, I got errors there. I think it's good to include these exemptions to keep this script runnable by data eng accounts.
whd
approved these changes
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #2387
Checklist for reviewer:
<username>:<branch>of the fork as parameter. The parameter will also show upin the logs of the
manual-trigger-required-for-forkCI task together with more detailed instructions.