Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(DENG-2120): migrated over checks defined in DIM for baseline_clients_last_seen fenix. #4656

Merged
merged 2 commits into from
Dec 6, 2023
Merged

feat(DENG-2120): migrated over checks defined in DIM for baseline_clients_last_seen fenix. #4656

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b75a22
migrated over checks defined in DIM for this type of dataset
kik-kik Dec 6, 2023
33080ea
Update sql_generators/glean_usage/templates/baseline_clients_last_see…
kik-kik Dec 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 53 additions & 2 deletions sql_generators/glean_usage/templates/baseline_clients_last_seen_v1.checks.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
{{ header }}

#fail
{#
We use raw here b/c the first pass is rendered to create the checks.sql
files, and the second pass is rendering of the checks themselves.
Expand All @@ -14,5 +13,57 @@
(you can also run them locally with `bqetl check run`).
#}
{% raw -%}
{{ is_unique(["client_id"], "submission_date = @submission_date") }}
#warn
{{ is_unique(["client_id"], where="submission_date = @submission_date") }}

#warn
{{ min_row_count(1, where="submission_date = @submission_date") }}

# warn
{{ not_null([
"submission_date",
"client_id",
"sample_id",
"first_seen_date",
"days_seen_bits",
"days_created_profile_bits",
"days_seen_session_start_bits",
"days_seen_session_end_bits"
], where="submission_date = @submission_date") }}

#warn
SELECT IF(
COUNTIF(normalized_channel NOT IN (
"nightly",
"aurora",
"release",
"Other",
"beta",
"esr"
)) > 0,
ERROR("Unexpected values for field normalized_channel detected."),
null
)
FROM `{{ project_id }}.{{ dataset_id }}.{{ table_name }}`
WHERE submission_date = @submission_date;

#warn
SELECT IF(
COUNTIF(NOT REGEXP_CONTAINS(CAST(country AS STRING), r"^[A-Z]{2}|\?\?$")) > 0,
ERROR("Some values in this field do not adhere to the ISO 3166-1 specification (2 character country code, for example: DE)."),
null
)
FROM `{{ project_id }}.{{ dataset_id }}.{{ table_name }}`
WHERE submission_date = @submission_date;

#warn
SELECT IF(
COUNTIF(NOT REGEXP_CONTAINS(CAST(telemetry_sdk_build AS STRING), r"^\d+\.\d+\.\d+$")) > 0,
ERROR("Values inside field telemetry_sdk_build not adhere to the expected format. Example: 23.43.33"),
null
)
FROM `{{ project_id }}.{{ dataset_id }}.{{ table_name }}`
WHERE submission_date = @submission_date;

{% endraw %}