Remove unnecessary fxci schema files; Add metadata file for new table #7007
+19
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These schemas are defined in `docker-etl` and validated via the BigQuery API here: https://github.com/mozilla/docker-etl/blob/379747a2641ea2a6c0dd113e59c940ea46b25a2d/jobs/fxci-taskcluster-export/fxci_etl/loaders/bigquery.py#L73 I'd like to have that be the source of truth and avoid duplicating the schema in bigquery-etl.
This is a new table I'm creating to convert task tags from a nested column in the tasks table to their own dedicated table. This is to make querying by multiple tags simpler.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The schemas for these tables are being created / validated in docker-etl, so I want to avoid needing to update them in two places.
The new
task_tags_v1table is being added in:mozilla/docker-etl#327
I'm not entirely sure if the table needs to exist or not before merging this metadata file.
Reviewer, please follow this checklist