Fix linkify with character entities (#501) #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes problems where serializing linkify output causes character entities in Characters tokens to be escaped.
|
@g-k This seems like the right thing to do. It copies some of the bits from the Cleaner over minus the sanitizing code. Does this raise any eyebrows for you? |
g-k
approved these changes
Jan 12, 2023
|
Thank you! |
stefanw
added a commit
to okfde/froide
that referenced
this pull request
May 23, 2023
bleach 6 fixes this in mozilla/bleach#692 Adding some types so SafeString's are easier to identify
stefanw
added a commit
to okfde/froide
that referenced
this pull request
May 24, 2023
bleach 6 fixes this in mozilla/bleach#692 Adding some types so SafeString's are easier to identify
github-merge-queue bot
pushed a commit
to okfde/froide
that referenced
this pull request
May 24, 2023
bleach 6 fixes this in mozilla/bleach#692 Adding some types so SafeString's are easier to identify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes problems where serializing linkify output causes character entities in Characters tokens to be escaped.
Fixes #501
Fixes #670