MNTOR-3812 - switch to Cirrus v2 output #5432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flozia
reviewed
Dec 19, 2024
src/app/(proper_react)/(redesign)/(authenticated)/user/(dashboard)/dashboard/View.tsx
Show resolved
Hide resolved
|
Preview URL 🚀 : https://blurts-server-pr-5432-mgjlpikfea-uk.a.run.app |
flozia
approved these changes
Dec 19, 2024
…cirrus-v2-output
…utput' into MNTOR-3812/switch-to-cirrus-v2-output
|
Cleanup completed - database 'blurts-server-pr-5432' destroyed, cloud run service 'blurts-server-pr-5432' destroyed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References:
Jira: MNTOR-3812
Description
Switch to the Cirrus v2 output. This requires changing the code that generates types based on the
nimbus.yaml.This is a bit cumbersome to do by hand, we should consider using some pre-existing code-generation tool for
this, but I think it works well enough for now. I can file a followup tech debt ticket for that.
How to test
Cirrus is used by just about every part of Monitor including the front page, so it's hard to miss. We also have unit test coverage.
Checklist (Definition of Done)