Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some refinements for the renewal page #5565

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Some refinements for the renewal page #5565

wants to merge 1 commit into from

Conversation

Vinnl
Copy link
Collaborator

@Vinnl Vinnl commented Jan 30, 2025

References:

Jira: MNTOR-3915
Figma: https://www.figma.com/design/CUTfhHTLckI7ZpolzBz3E6?node-id=8235-1075&m=dev#1100739205

Description

  • Less spacing between the title and content,
  • decrease height of the logo,
  • less spacing between the CTA and the terms link, and
  • link directly to the pricing section on the landing page.

Checklist (Definition of Done)

  • Localization strings (if needed) have been added.
  • Commits in this PR are minimal and have descriptive commit messages.
  • I've added or updated the relevant sections in readme and/or code comments
  • I've added a unit test to test for potential regressions of this bug. - N/A, visual
  • If this PR implements a feature flag or experimentation, I've checked that it still works with the flag both on, and with the flag off.
  • If this PR implements a feature flag or experimentation, the Ship Behind Feature Flag status in Jira has been set
  • Product Owner accepted the User Story (demo of functionality completed) or waived the privilege.
  • All acceptance criteria are met.
  • Jira ticket has been updated (if needed) to match changes made during the development process.
  • Jira ticket has been updated (if needed) with suggestions for QA when this PR is deployed to stage.

@Vinnl
Some refinements for the renewal page
1a8ff68 
- Less spacing between the title and content,
- decrease height of the logo,
- less spacing between the CTA and the terms link, and
- link directly to the pricing section on the landing page.
@Vinnl Vinnl added the Review: XS Code review time: up to 30min label Jan 30, 2025
@Vinnl Vinnl requested review from codemist and flozia January 30, 2025 14:49
@Vinnl Vinnl self-assigned this Jan 30, 2025
@github-actions GitHub Actions
Copy link

Preview URL 🚀 : https://blurts-server-pr-5565-mgjlpikfea-uk.a.run.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flozia flozia flozia approved these changes

@codemist codemist Awaiting requested review from codemist

Assignees

@Vinnl Vinnl

Labels
Review: XS Code review time: up to 30min
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vinnl @flozia