Workaround inaccurate Jest coverage reporting #5623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This directly applies the following Pull Request: SimenB/collect-v8-coverage#235 It's not entirely clear why it's needed, but it seems reasonable and harmless enough, and there are no signs that Jest is really maintained anymore, so a longer-term fix does not appear to be forthcoming. Thus, this'll at least properly unblock Node upgrades and other annoying coverage surprises.
This reverts commit 2886eb2.
This reverts commit e57bfd6.
This reverts commit aeba4e2.
|
Preview URL 🚀 : https://blurts-server-pr-5623-mgjlpikfea-uk.a.run.app |
flozia
approved these changes
Feb 13, 2025
Contributor
flozia
left a comment
flozia
left a comment
There was a problem hiding this comment.
Thank you for this. So nice to see those c8 ignore’s go.
rhelmer
approved these changes
Feb 13, 2025
|
Cleanup completed - database 'blurts-server-pr-5623' destroyed, cloud run service 'blurts-server-pr-5623' destroyed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This directly applies the following Pull Request:
SimenB/collect-v8-coverage#235
It's not entirely clear why it's needed, but it seems reasonable
and harmless enough, and there are no signs that Jest is really
maintained anymore, so a longer-term fix does not appear to be
forthcoming. Thus, this'll at least properly unblock Node upgrades
and other annoying coverage surprises.