-
Notifications
You must be signed in to change notification settings - Fork 238
Migrate addresses in table onerep_profiles #5688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Preview URL 🚀 : https://blurts-server-pr-5688-mgjlpikfea-uk.a.run.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is correct, one thing to consider is that if you do use the rollback, it will only take the first address losing the others. We should try to avoid having to use it, but if we do that's something to consider. The only way this would matter is if we enable the feature for users before finding a serious issue that warrants rollback, so let's try not to do that e.g. testing carefully behind an allow-listed flag :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this is fine if we first update the existing UI to write to both fields, in which case we can still safely roll this back. As soon as we enable people to add multiple addresses, we can consider this migration completed and should no longer roll it back.
Cleanup completed - database 'blurts-server-pr-5688' destroyed, cloud run service 'blurts-server-pr-5688' destroyed |
References:
PR: #5660
Jira: MNTOR-4065
Description
Builds up on the migration file for PR #5660: Migrates
city_name
andstate_code
to the new columnaddresses
.How to test
npm run db:migrate
: The tableonerep_profiles
should contain the applied changes.npm run db:rollback
: The tableonerep_profiles
should have its initial state.