Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404s on staging #314

Closed
humphd opened this issue May 22, 2015 · 6 comments
Closed

404s on staging #314

humphd opened this issue May 22, 2015 · 6 comments

Comments

@humphd
Copy link

humphd commented May 22, 2015

I'm seeing these 3 404s on staging right now, none of which should happen afaict:

GET https://mozillathimblelivepreview.net/bramble/dist/thirdparty/filer-dialogs/style/style.css
GET https://mozillathimblelivepreview.net/bramble/dist/thirdparty/filer-dialogs/bower_components/font-awesome/css/font-awesome.min.css
GET https://mozillathimblelivepreview.net/bramble/dist/styles/bramble_overrides.css
@humphd
Copy link
Author

humphd commented May 22, 2015

@gideonthomas, @JordanTheriault can you two look, these are things from your recent bugs.

@sedge
Copy link

sedge commented May 22, 2015

Filer-dialogs was never corrected, but there's a WIP patch I wrote that got lost. It needs lazy loading of font-awesome once to be shared between any extensions that need. it.

@sedge
Copy link

sedge commented May 22, 2015

bramble_overrides.css is the firefox fix, but hasn't been forced to be included in the build step which is why it can't find it on staging.

@sedge
Copy link

sedge commented May 22, 2015

In fact, @JordanTheriault has a patch for the bramble_overrides stuff here: https://github.com/humphd/brackets/pull/310/files

@humphd
Copy link
Author

humphd commented May 22, 2015

The filer-dialogs stuff got changed yesterday, see https://github.com/humphd/brackets/pull/309. @gideonthomas, why is it 404ing?

@gideonthomas
Copy link

looking into it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants