Issue78 Move away from Source Code Pro web fonts in favour of system fonts #110
Conversation
| @@ -457,3 +457,5 @@ | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| @sansFontFamily: Helvetica, Arial, "Meiryo UI", "ＭＳ Ｐゴシック", "MS PGothic", sans-serif; | |||
There was a problem hiding this comment.
those are three very WIndows specific fonts, all of which are from the Asian langauges... Where are the regular Sans serif fonts available in modern Windows, and where are the better OSX fonts? (and you probably want those at the front of the family, then, since Helvetica and Arial are considered websafe and will thus always get selected. Any system with the followup fonts has Arial, for instance)
There was a problem hiding this comment.
This is what Brackets does, we're just removing the web font. I'd rather file a new bug afterward to evaluate our font choices as part of a larger UX overhaul in Thimble vs. doing it in this PR.
| @@ -379,3 +379,5 @@ | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| @sansFontFamily: Helvetica, Arial, "Meiryo UI", "ＭＳ Ｐゴシック", "MS PGothic", sans-serif; | |||
There was a problem hiding this comment.
Can you confirm that defining variables after they are used is OK with LESS? I'm not sure, but you might want to move this to the top of the file. I might be wrong, check it out?
AJDBenner
force-pushed
the
issue78
branch
3 times, most recently
from
cd5cede to
3b3eeb2
Compare
Issue78 Move away from Source Code Pro web fonts in favour of system fonts
#78