Fix #150 - Fix colour editor for use in browsers that don't use -webkit- prefix #158
Conversation
| @@ -199,10 +208,13 @@ | |||
| .color-editor section .slider.opacity-slider { | |||
| background-image: url("../img/color_thumb_back.png"); | |||
| background-size: 8px; | |||
| margin-right: 0px; | |||
| margin-right: 0px; | |||
There was a problem hiding this comment.
Revert this change, please. Spurious whitespace-only change are to be avoided, since they make blame info harder to untangle.
|
Please fix issues I've pointed out above. How does this look in IE9/10? @le717, any thoughts? This change seems like something we should just do upstream, to be honest. I can't imagine there will be a lot of resistence, since it won't affect the |
| -moz-font-smoothing: antialiased; | ||
| -o-font-smoothing: antialiased; | ||
| -ms-font-smoothing: antialiased; | ||
| font-smoothing: antialiased; |
There was a problem hiding this comment.
Is font-smoothing even a valid (read: non-WebKit only) property, and do all these prefixes even exist? The closest I can find is a font-smooth property from a very old (2002) CSS3 draft, and it has long been dropped from the spec.
There was a problem hiding this comment.
Good question. We have https://developer.mozilla.org/en-US/docs/Web/CSS/font-smooth in Firefox, but it's not really recommended. Probably we should just revert this section of the patch, and leave it unchanged.
|
@humphd Aside from the few notes, I see no harm in landing this upstream, especially since it does not effect us at all (if anything, it may be good as it switches us to use the standard gradient syntax). I'm not sure if an issue won't be raised about the prefixes, though. |
AJDBenner
force-pushed
the
issue150
branch
3 times, most recently
from
f918e1d to
7f63ffc
Compare
| @@ -88,7 +88,7 @@ define(function (require, exports, module) { | |||
| this.$opacitySlider = this.$element.find(".opacity-slider"); | |||
| this.$opacitySelector = this.$element.find(".opacity-slider .selector-base"); | |||
| this.$swatches = this.$element.find(".swatches"); | |||
|
|
|||
| console.log("LOOK HERE", this.$opacityGradient.selector); | |||
| @@ -88,7 +88,6 @@ define(function (require, exports, module) { | |||
| this.$opacitySlider = this.$element.find(".opacity-slider"); | |||
| this.$opacitySelector = this.$element.find(".opacity-slider .selector-base"); | |||
| this.$swatches = this.$element.find(".swatches"); | |||
|
|
|||
|
You should collect screenshots of this running in all the browsers, and also test it in Desktop Brackets. Then we should rebase against Brackets' master and do a PR upstream. |
Just be sure to note the question about ordering in https://github.com/humphd/brackets/pull/158#discussion_r27601425. |
AJDBenner
force-pushed
the
issue150
branch
2 times, most recently
from
04740f6 to
1d8d9b5
Compare
|
I've compiled screenshots for all the browsers. Chrome Firefox Internet Explorer 10 Opera Safari Desktop Brackets |
|
I filed this upstream adobe#10853 |
AJDBenner
force-pushed
the
issue150
branch
2 times, most recently
from
f77d6fa to
ac9d939
Compare
…e -webkit- prefix
Fix #150. This is what the fix looks like in Firefox.