Fix #336: add autosave extension #337
Conversation
| @@ -60,7 +61,8 @@ define(function (require, exports, module) { | |||
| var extraExtensions = [ | |||
| "brackets-cdn-suggestions", // https://github.com/szdc/brackets-cdn-suggestions | |||
| "ImageUrlCodeHints", | |||
| "HTMLHinter" | |||
| "HTMLHinter", | |||
| "Autosave" | |||
There was a problem hiding this comment.
Why do we need it as an extra extension as well as a default extension? IMO it should just be a default extenstion
There was a problem hiding this comment.
I think the bramble extension is getting too big, and I wanted an easy way to turn this feature on/off for user testing.
There was a problem hiding this comment.
So if you do ?disableExtensions=Autosave, even though it's a default extension, we can disable it?
There was a problem hiding this comment.
Actually, just tested it. It doesn't need to be in the extraExtensions list to allow disabling.
There was a problem hiding this comment.
Good catch, I forgot to remove it from here. My thinking was to put it in the default list, and yes, you'd be able to disable with ?disableExtensions=Autosave. I'll remove from extra.
|
one comment...looks good otherwise and seems to be working fine r+ |
|
Actually, can we move the time before save config value to the env? It seems like it would make more sense for it to be there |
|
@gideonthomas what does "to the env" mean? We don't have an env for Bramble. I could make these prefs that we can change via PrefManger, I suppose. Do we care that much? Changing this value in the extension is pretty easy: it's a 1 line change; otherwise we have to deal with prefs over in bramble for this extension. |
|
Oh right, we don't have one in the context of the browser. Ok then nvm |
Move Autosave to extensions/default, add save-on-editor-change logic Fix typo on SAVE_ON_EDTIOR_CHANGE Remove Autosave from extraExtensions list (added twice by accident)
To test this, open your filetree, and start changing files. Watch the dot beside your working files (which means they are dirty), and notice it vanish 15s after you make changes!