Revert change to how Brackets gets loaded, so that utils/Compatibility is done first for IE #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y is done first for IE
| require("brackets"); | ||
| // Load the brackets module. This is a self-running module that loads and | ||
| // runs the entire application. | ||
| require(["brackets"]); |
There was a problem hiding this comment.
Why does this make a difference to the load order?
|
Curiosity aside, r+ |
humphd
added a commit
that referenced
this pull request
Jun 22, 2015
Revert change to how Brackets gets loaded, so that utils/Compatibility is done first for IE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now IE can't load Bramble due to
trimRightmissing onString. I fixed this upstream a long time ago...no idea when this got broken, but the fix is to do what I did upstream for IE originally (note the use of[..]around the module). This gets Bramble loading again in IE.