Split filesystem impl, fixes https://github.com/mozilla/thimble.webmaker.org/issues/1150 #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -142,7 +143,7 @@ define(function (require, exports, module) { | |||
|
|
|||
| deferred.always(function() { | |||
| // Preload BlobURLs for all assets in the filesystem | |||
| BlobUtils.preload(root, function(err) { | |||
| FileSystemCache.refresh(function(err) { | |||
There was a problem hiding this comment.
This is awesome! I no longer need to figure out a root to pass in!
|
This is a great patch, it will really fix a lot of issues! A few questions, r=me with that! |
…sync Refactor BlobUtils.preload() into separate module Undoing some of my work to fix circular deps Yield to main thread during rewriting so we don't block UI for sync work Review fixes
humphd
force-pushed
the
split-filesystem-impl
branch
from
c402682 to
b7dc541
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was an attempt to move all the Blob URL caching into
BracketsFiler, but it turns out to be impossible. I've made a bunch of good changes though, so I want to take the rest of it. A few of the things you'll find in it:FileSystemCache)BracketsFilerdirectly vs. via Brackets APIsetTimeoutto yield control to the main thread more often. Since almost none of the code is async, a really big web page could block the main thread for a long time. This will do it in chunks.