-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a test for the HTTP service bug classification with missing bugs #3363
Conversation
I had to close the other pull request because it will change multiple files if merged. |
@Emeka-Onwuepe this PR is targeting the same issue as #3358. Why did you close #3358 in the first place? |
You could revert the unwanted changes; you do not need to open a new pull request. This pollutes the project. |
Should I close this, sir? |
You could delete those changes without opening a new PR. See: https://git-scm.com/book/en/v2/Git-Basics-Undoing-Things
No, you can continue working on this PR. If the PR is not ready, please convert it to a draft pull request. When it is ready, you can convert it back. |
Thanks for the link and guidance. It is indeed a learning journey for me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @Emeka-Onwuepe! Please see my comments.
Well noted Sir, I will do the corrections |
Co-authored-by: Suhaib Mujahid <suhaibmujahid@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @Emeka-Onwuepe! LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
fixes #1368