Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test for the HTTP service bug classification with missing bugs #3363

Merged
merged 15 commits into from
Apr 5, 2023

Conversation

Emeka-Onwuepe
Copy link
Contributor

fixes #1368

@Emeka-Onwuepe
Copy link
Contributor Author

I had to close the other pull request because it will change multiple files if merged.

@suhaibmujahid
Copy link
Member

@Emeka-Onwuepe this PR is targeting the same issue as #3358. Why did you close #3358 in the first place?

@suhaibmujahid
Copy link
Member

I had to close the other pull request because it will change multiple files if merged.

You could revert the unwanted changes; you do not need to open a new pull request. This pollutes the project.

@Emeka-Onwuepe
Copy link
Contributor Author

Should I close this, sir?

@suhaibmujahid
Copy link
Member

Sir, it has some of the previous work I did. I was afraid it might affect other file

You could delete those changes without opening a new PR. See: https://git-scm.com/book/en/v2/Git-Basics-Undoing-Things

Should I close this, sir?

No, you can continue working on this PR. If the PR is not ready, please convert it to a draft pull request. When it is ready, you can convert it back.

@Emeka-Onwuepe Emeka-Onwuepe marked this pull request as draft March 16, 2023 19:34
@Emeka-Onwuepe Emeka-Onwuepe marked this pull request as ready for review March 17, 2023 07:01
@Emeka-Onwuepe
Copy link
Contributor Author

Sir, it has some of the previous work I did. I was afraid it might affect other file

You could delete those changes without opening a new PR. See: https://git-scm.com/book/en/v2/Git-Basics-Undoing-Things

Should I close this, sir?

No, you can continue working on this PR. If the PR is not ready, please convert it to a draft pull request. When it is ready, you can convert it back.

Thanks for the link and guidance. It is indeed a learning journey for me

Copy link
Member

@suhaibmujahid suhaibmujahid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Emeka-Onwuepe! Please see my comments.

http_service/tests/test_bug_classification.py Outdated Show resolved Hide resolved
http_service/tests/test_bug_classification.py Outdated Show resolved Hide resolved
http_service/tests/test_bug_classification.py Outdated Show resolved Hide resolved
http_service/tests/test_bug_classification.py Outdated Show resolved Hide resolved
http_service/tests/test_bug_classification.py Outdated Show resolved Hide resolved
@Emeka-Onwuepe
Copy link
Contributor Author

Well noted Sir, I will do the corrections

@Emeka-Onwuepe Emeka-Onwuepe marked this pull request as draft March 27, 2023 11:42
@Emeka-Onwuepe Emeka-Onwuepe marked this pull request as ready for review March 27, 2023 14:32
.gitignore Outdated Show resolved Hide resolved
http_service/tests/test_bug_classification.py Outdated Show resolved Hide resolved
http_service/tests/test_bug_classification.py Outdated Show resolved Hide resolved
@Emeka-Onwuepe Emeka-Onwuepe marked this pull request as draft March 27, 2023 19:56
@Emeka-Onwuepe Emeka-Onwuepe marked this pull request as draft March 27, 2023 19:56
@Emeka-Onwuepe Emeka-Onwuepe marked this pull request as ready for review March 27, 2023 20:07
suhaibmujahid
suhaibmujahid previously approved these changes Apr 4, 2023
Copy link
Member

@suhaibmujahid suhaibmujahid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Emeka-Onwuepe! LGTM.

http_service/tests/test_bug_classification.py Outdated Show resolved Hide resolved
@suhaibmujahid suhaibmujahid requested a review from marco-c April 4, 2023 22:48
Copy link
Collaborator

@marco-c marco-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@marco-c marco-c merged commit 7d8f070 into mozilla:master Apr 5, 2023
@Emeka-Onwuepe Emeka-Onwuepe deleted the http_test branch April 7, 2023 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a test for the HTTP service bug classification with missing bugs
3 participants