Generate json snapshots in all snapshot tests #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, the tests are failing because I generated the snapshots on top of #296, oops. |
Previously these tests would only generate snapshots for the human output of cargo vet. With this change, json snapshots are also produced. This both acts as a test for the json output from cargo vet, as well as a way to see more information about the vet's results, as json output is occasionally more detailed than human output. Finally, it also acts as a source of examples for the JSON output.
mystor
added a commit
to mystor/cargo-vet
that referenced
this pull request
Aug 22, 2022
The changes in mozilla#296 changed some test expectations which were only added in mozilla#299, so when both were landed, it caused test failures. This fixes those test failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously these tests would only generate snapshots for the human
output of cargo vet. With this change, json snapshots are also produced.
This both acts as a test for the json output from cargo vet, as well as
a way to see more information about the vet's results, as json output is
occasionally more detailed than human output.
Finally, it also acts as a source of examples for the JSON output.