Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Actix audit file to registry #637

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Add Actix audit file to registry #637

merged 1 commit into from
Oct 16, 2024

Conversation

robjtede
Copy link
Contributor

@robjtede robjtede commented Oct 14, 2024

I've started an audit log for all Actix first-party and some third-party ecosystem crates.

@robjtede robjtede marked this pull request as ready for review October 14, 2024 06:21
Copy link
Collaborator

@mystor mystor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I notice your audits.toml file has inline comments, suggesting it is manually managed, rather than created using cargo-vet. Are you aware of the stability requirements of an importable audits.toml file (e.g. never removing an audit from the file) which would normally be managed by cargo vet if it was used to generate the file?

I notice that some audits were removed from the file in previous changes (such as this one). Changes like this could cause vet to start failing for folks who are depending on your published audits.

@robjtede
Copy link
Contributor Author

robjtede commented Oct 16, 2024

manually managed

Totally get the concern and happy to recreate this file purely with the cargo vet commands before telling more people about it.

some audits were removed from the file in previous changes

yes, i'd learned about wildcard-audits and that seemed like an obvious improvement for the self-certify cases

stability requirements of an importable audits.toml file (e.g. never removing an audit from the file)

yes, very reasonable requirement and will certainly uphold it going forwards


end of the day, you guys are the pros with this so i'd be a fool not to take your advice on how to make this a good experience for everyone

Copy link
Collaborator

@mystor mystor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just wanted to check in about those things given the manually curated audits.toml file before adding actix to the registry :-)

@mystor mystor merged commit 579fb7d into mozilla:main Oct 16, 2024
13 checks passed
@robjtede robjtede deleted the patch-1 branch October 16, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants