Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse unsafe attributes #1019

Closed
wants to merge 1 commit into from
Closed

Parse unsafe attributes #1019

wants to merge 1 commit into from

Conversation

Coekjan
Copy link
Contributor

@Coekjan Coekjan commented Oct 27, 2024

Closes #1013 . The linked issue is urgent, so @emilio (hope we can resolve the issue as soon as possible).

The dependency syn is updated in order to handle the unsafe attributes.

@emilio emilio mentioned this pull request Oct 27, 2024
Merged
emilio
emilio approved these changes Oct 27, 2024
View reviewed changes
Copy link
Collaborator

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good to me. There's some minor nits and an extra toml change that needs to happen in order for CI to be happy. I sent #1020 with those.

@emilio emilio closed this Oct 27, 2024
@Coekjan Coekjan deleted the unsafe-attrs branch October 27, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilio emilio emilio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parse unsafe in attributes
2 participants
@Coekjan @emilio