Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove serde_derive dependency #179

Closed
wants to merge 1 commit into from

Conversation

ignatenkobrain
Copy link

It was pinned to be used with standalone-syn. Since we have switched
back to syn, it is no longer needed.

Signed-off-by: Igor Gnatenko i.gnatenko.brain@gmail.com

It was pinned to be used with standalone-syn. Since we have switched
back to syn, it is no longer needed.

Signed-off-by: Igor Gnatenko <i.gnatenko.brain@gmail.com>
@cuviper
Copy link
Contributor

cuviper commented Jul 26, 2018

It was pinned so that the version of syn used by serde-derive would be older, distinct from the version used by cbindgen itself. This is because serde-derive with current syn will enable the proc-macro feature (by default), which dynamically links it to compiler libraries. That's fine for transient derive plugins, but then cbindgen with that same syn is stuck also linked to compiler libraries. Cargo doesn't have a way to say you want the same syn built different ways, so you could also have it without proc-macro.

For rustup users, this is a problem because your installed ~/.cargo/bin/cbindgen will depend on the exact compiler version activated, and will fail when that one is not in LD_LIBRARY_PATH. Similarly for your Fedora build, you've got a few unsatisfied library Requires, as the rust rpm explicitly filters its libraries from auto-Provides.

@eqrion
Copy link
Collaborator

eqrion commented Oct 1, 2018

I'm going to close this as there's no good path forward. Once #203 is resolved we can remove the pin.

@eqrion eqrion closed this Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants