Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to serde_derive 1.0.58 #207

Merged
merged 1 commit into from
Oct 1, 2018
Merged

Conversation

cuviper
Copy link
Contributor

@cuviper cuviper commented Sep 10, 2018

This will in turn build with syn 0.13 and quote 0.5, which is still
distinct from cbindgen's own dependencies, so it won't get "infected" by
the proc-macro feature.

@cuviper
Copy link
Contributor Author

cuviper commented Sep 10, 2018

I've confirmed that the resulting binary is still independent of rustc shared libraries on x86_64-unknown-linux-gnu and x86_64-pc-windows-msvc, but someone should probably check macos too.

This will in turn build with `syn 0.13` and `quote 0.5`, which is still
distinct from cbindgen's own dependencies, so it won't get "infected" by
the proc-macro feature.
@cuviper
Copy link
Contributor Author

cuviper commented Sep 10, 2018

I just added proc-macro2 to the inline comment, because overlapping that would still be a problem for the features even if syn and quote were distinct.

@eqrion
Copy link
Collaborator

eqrion commented Oct 1, 2018

@cuviper I can confirm it works on OSX as well. Thanks!

@eqrion eqrion merged commit de6c08c into mozilla:master Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants