Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test for generic pointer parameter #453

Closed
wants to merge 1 commit into from
Closed

Add a test for generic pointer parameter #453

wants to merge 1 commit into from

Conversation

kvark
Copy link
Contributor

@kvark kvark commented Jan 12, 2020

The test is a reduced version of gfx-rs/wgpu#440 (comment) . It currently fails. cc @emilio

@emilio
Copy link
Collaborator

emilio commented Jan 12, 2020

Ah, so that panic is basically an unimplemented!. Someone needs to come up with a mangling scheme for that, but it shouldn't be too hard.

@TheKK
Copy link
Contributor

TheKK commented Mar 3, 2020

Is there any name mangling guideline we can follow?
For this PR we need to implement mangling for Type::ConstPtr(Box<Type>) and it's a little tricky to handle nested type if we want to present them in flat type name.

emilio added a commit to emilio/cbindgen that referenced this pull request Apr 10, 2020
@emilio
Handle mangling pointers.
a44a471 
Ugly, but better than crashing.

Closes mozilla#506.
Closes mozilla#453.
emilio added a commit to emilio/cbindgen that referenced this pull request Apr 10, 2020
@emilio
Handle mangling pointers.
6a18639 
Ugly, but better than crashing.

Closes mozilla#506.
Closes mozilla#453.
@emilio emilio mentioned this pull request Apr 10, 2020
Merged
@emilio emilio closed this in #508 Apr 10, 2020
emilio added a commit that referenced this pull request Apr 10, 2020
@emilio
Handle mangling pointers.
33d9ecf 
Ugly, but better than crashing.

Closes #506.
Closes #453.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kvark @emilio @TheKK