Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename duplicate crate in workspace #950

Merged
merged 2 commits into from
May 7, 2024
Merged

Rename duplicate crate in workspace #950

merged 2 commits into from
May 7, 2024

Conversation

gferon
Copy link
Contributor

@gferon gferon commented May 7, 2024

Otherwise, cargo prints a warning when using cbindgen as a build-dependency in my workspace:

warning: skipping duplicate package `single_crate` found at `/Users/gferon/.cargo/git/checkouts/cbindgen-4f7d248bb26fc43d/10f32b0/tests/depfile/single_crate`
warning: skipping duplicate package `single_crate` found at `/Users/gferon/.cargo/git/checkouts/cbindgen-4f7d248bb26fc43d/10f32b0/tests/depfile/single_crate_default_config`

emilio
emilio approved these changes May 7, 2024
View reviewed changes
Copy link
Collaborator

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, ok, but we should try to exclude those tests crates somehow else...

@gferon
Copy link
Contributor Author

gferon commented May 7, 2024 •
edited
Loading

I added them to workspace.exclude and this seems to do the trick as well. You can still compile those crates when going in their respective directories (this means CI or dev workflows might need adjustment).

@emilio emilio added this pull request to the merge queue May 7, 2024
Merged via the queue into mozilla:master with commit a5f865d May 7, 2024
1 of 2 checks passed
@gferon gferon mentioned this pull request May 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilio emilio emilio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gferon @emilio