Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjusting paths for mls compatibility #149

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Adjusting paths for mls compatibility #149

merged 1 commit into from
Mar 18, 2024

Conversation

alexcottner
Copy link
Contributor

Adjusting paths for MLS sunset compatibility. MLS didn't use /api prefix.

leplatrem
leplatrem approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@leplatrem leplatrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised there's no doc or tests to modify :)

Also, this change only affects the endpoints introduced in #133, right?

@alexcottner
Copy link
Contributor Author

this change only affects the endpoints introduced in #133, right?

Correct, the paths were just slightly off. Re: unit tests hit the functionality directly so nothing to actually change there. Which is nice for this case.

@alexcottner alexcottner merged commit 3bacc1f into master Mar 18, 2024
2 checks passed
@alexcottner alexcottner deleted the mls-path-fix branch March 18, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leplatrem leplatrem leplatrem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexcottner @leplatrem