Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coalescing invalid keys to 'invalid-key' for metrics #159

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Coalescing invalid keys to 'invalid-key' for metrics #159

merged 1 commit into from
Jun 12, 2024

Conversation

alexcottner
Copy link
Contributor

Seeing some messy metric data from invalid keys. Coalescing those all to invalid-key for metrics.
Updated unit tests.

@alexcottner alexcottner marked this pull request as ready for review June 12, 2024 20:15
@alexcottner alexcottner requested a review from leplatrem June 12, 2024 20:15
mostlygeek
mostlygeek approved these changes Jun 12, 2024
View reviewed changes
Copy link

@mostlygeek mostlygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

R+

@alexcottner alexcottner merged commit 8e531cd into master Jun 12, 2024
2 checks passed
@alexcottner alexcottner deleted the invalid-key branch June 12, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mostlygeek mostlygeek mostlygeek approved these changes

@cvalaas cvalaas cvalaas approved these changes

@leplatrem leplatrem Awaiting requested review from leplatrem

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexcottner @mostlygeek @cvalaas