Add Dockerflow to the backend application #1277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvaBardou
force-pushed
the
setup-dockerflow
branch
from
1423d7a to
ef7a035
Compare
La0
reviewed
Aug 17, 2022
EvaBardou
force-pushed
the
setup-dockerflow
branch
from
aed4683 to
da898e1
Compare
Collaborator
Author
|
I retrieved the image built by Taskcluster and ran it locally. Dockerflow seems to work properly and the
|
La0
previously approved these changes
Aug 17, 2022
Collaborator
La0
left a comment
La0
left a comment
There was a problem hiding this comment.
Overall approve, simply add some unit tests (hopefully that should be easy following what's already in backend/code_review_backend/issues/tests/test_api.py)
EvaBardou
force-pushed
the
setup-dockerflow
branch
from
d64730a to
32af870
Compare
abpostelnicu
approved these changes
Aug 18, 2022
Contributor
|
Thank you for doing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1226