Join the selectors and call querySelectorAll only once

mozilla · Oct 25, 2019 · fae4562 · fae4562
1 parent 86dc645
commit fae4562
Showing 1 changed file with 14 additions and 14 deletions.
diff --git a/src/content_script.js b/src/content_script.js
@@ -473,20 +473,20 @@ const facebookDetectedElementsArr = [];
 
 function patternDetection(selectionArray, socialActionIntent){
   // console.log("patternDetection");
-  for (let querySelector of selectionArray) {
-    for (let item of document.querySelectorAll(querySelector)) {
-      // overlay the FBC icon badge on the item
-      if (!item.classList.contains("fbc-has-badge") && !isPinterest(item) && !parentIsBadged(item)) {
-        // console.log([querySelector, item]);
-        const itemUIDClassName = "fbc-UID_" + (facebookDetectedElementsArr.length + 1);
-        const itemUIDClassTarget = "js-" + itemUIDClassName;
-        const socialAction = socialActionIntent;
-        facebookDetectedElementsArr.push(itemUIDClassName);
-        addFacebookBadge(item, itemUIDClassTarget, socialAction);
-        item.classList.add("fbc-has-badge");
-        item.classList.add(itemUIDClassName);
-        // console.log(itemUIDClassName);
-      }
+  let querySelector = selectionArray.join(",");
+
+  for (let item of document.querySelectorAll(querySelector)) {
+    // overlay the FBC icon badge on the item
+    if (!item.classList.contains("fbc-has-badge") && !isPinterest(item) && !parentIsBadged(item)) {
+      // console.log([querySelector, item]);
+      const itemUIDClassName = "fbc-UID_" + (facebookDetectedElementsArr.length + 1);
+      const itemUIDClassTarget = "js-" + itemUIDClassName;
+      const socialAction = socialActionIntent;
+      facebookDetectedElementsArr.push(itemUIDClassName);
+      addFacebookBadge(item, itemUIDClassTarget, socialAction);
+      item.classList.add("fbc-has-badge");
+      item.classList.add(itemUIDClassName);
+      // console.log(itemUIDClassName);
     }
   }
 }