Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facebook Container 2.3.3 messes up with font size and colors #863

Closed
mdorier opened this issue Sep 8, 2022 · 6 comments
Closed

Facebook Container 2.3.3 messes up with font size and colors #863

mdorier opened this issue Sep 8, 2022 · 6 comments

Comments

@mdorier
Copy link

mdorier commented Sep 8, 2022

  • Facebook Container Version: 2.3.3
  • Operating System + Version: Mac OS 12.5.1
  • Firefox Version: 104.0.2
  • Other installed Add-ons + Version + Enabled/Disabled-Status:

I'm on Mac OS 12.5.1 with Firefox 104.0.2 and the latest version of the Facebook Container plugin (which I have been using for years without any issues). Right now it started messing up fonts on some websites. For instance on Wikipedia it reduces the font size. On Github it reduces the font size and some text is left black even on Github's dark mode, when it should be white.

@kutiny
Copy link

kutiny commented Sep 8, 2022

I have the exact same problem (same SO + plugin + firefox version)
In addition I saw a problem with content_script.js on line 694
for (let item of target.querySelectorAll(querySelector)) {
TypeError: target.querySelectorAll is not a function

@kutiny
Copy link

kutiny commented Sep 8, 2022

Dup: #862

@multun
Copy link

multun commented Sep 8, 2022

the root cause is this change and related commits by @codemist which adds new CSS to the body of all sites, not just facebook-related elements

@zelch
Copy link

zelch commented Sep 8, 2022

Yep, between that change and 2b141da, the result breaks a good chunk of the websites that I use.

And since I also use Dark Reader, the impact is even bigger.

I spent a good half hour+ trying to figure out what was breaking everything.

@LoZeno
Copy link

LoZeno commented Sep 8, 2022

Just adding myself to the list of people affected by this issue, lots of the website I visit have black text on black background if I keep Facebook Container active while using dark mode. I'm on Windows and using Firefox Developer Edition 105.0b8

@bakulf
Copy link
Collaborator

bakulf commented Sep 8, 2022

Version 2.3.3 was buggy and, as a temporary fix, we just released a v2.3.4 as a v2.4.2 repackaged. Please, update the add-on to have a fix for this issue.
All the features introduced by v2.3.3 will be released in v2.3.5 as soon as possible.

@bakulf bakulf closed this as completed Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants