CSS fonts rules overrides website ones

[noreiller]

• Facebook Container Version: 2.3.3
• Operating System + Version: Ubuntu 22.04
• Firefox Version: 101.0
• Other installed Add-ons + Version + Enabled/Disabled-Status:

Actual behavior

When enabling this extension, other websites have graphic issues due this part of the extension: https://github.com/mozilla/contain-facebook/blob/main/src/content_script.css#L12-L15.

Expected behavior

No graphic impact on other websites.

Steps to reproduce

1. Enable the extension
2. Visit any website
3. The font rules applied are not the one setup by the website

Notes

[VulumeCode]

Same problem here. Started an hour ago, disabling the extension fixes the problem.

[mvdve]

The contain facebook extension adds a global stylesheet with the code:

body { --blue60: #0060df; --blue70: #003eaa; --primaryText: #15141A; --secondaryText: #5B5B66; --grey20: #ededf0; --light-gray: #F0F0F4; --white: #ffffff; --transition: all .15s cubic-bezier(.07,.95,0,1); --borders: 1px solid #ededf0; font-size: 13px; font-weight: 400; color: #15141A; font-family: "SF Pro Text", 'Segoe UI', Roboto, Oxygen, Ubuntu, Cantarell, 'Open Sans', 'Helvetica Neue', sans-serif;

This stylesheet overrules the sheet from the website and so resets the font size.

See commit c8c92e2ff21576931a5046b96fad839f7aa9151a where the changes where added.

[lisenet]

Same problem here. Started this morning after upgrade to 2.3.3, disabling the extension fixes the problem.

[adrian-pasten]

Same here the file content_script.css overwrite any changes on other website

[harrygr]

I noticed this today also. The font stack in content_script.css seems to override many websites' base font stack. It looks like other styles may also be applied.

E.g. Github

[milutinke]

Same problem for me, had to disable the extension.

[Felixoid]

Here's a manual how to downgrade it #858 (comment)

[milutinke]

Here's a manual how to downgrade it #858 (comment)

Thanks

[ann4belle]

How the hell does something like this make it into a full release?

[lisenet]

How the hell does something like this make it into a full release?

Lack of testing and QA.

[noreiller]

Thanks @rittme for the PR

[noreiller]

Thanks @rittme for the PR

@noreiller, did you mean to link to #860?

Yes, thanks... 😅 It's updated now.

[zelch]

#863 is the same issue.

[bakulf]

Version 2.3.3 was buggy and, as a temporary fix, we just released a v2.3.4 as a v2.4.2 repackaged. Please, update the add-on to have a fix for this issue.
All the features introduced by v2.3.3 will be released in v2.3.5 as soon as possible.