Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facebook Domain Overhaul (many, many added) #499

Closed
wants to merge 10 commits into from
Closed

Facebook Domain Overhaul (many, many added) #499

wants to merge 10 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 11, 2019

This domain addition covers much more of Facebook's mark on the internet.

@maxxcrawford
Copy link
Collaborator

@JesseCharlie The CI is failing. Can you resolve that?

@ghost
Copy link
Author

ghost commented Aug 12, 2019

Yes. I am debugging now.

@ghost
Copy link
Author

ghost commented Aug 12, 2019

Oh. It was a little canonical domain problem because in the test js it looks for cookie declaration on the www subdomain of Facebook, even though this extension declares all subdomains included.
Now the build passed. :)

@maxxcrawford
Copy link
Collaborator

@groovecoder We need to discuss the breakage risk for adding so many domains.

@maxxcrawford
Copy link
Collaborator

Related to #558

@maxxcrawford
Copy link
Collaborator

@JesseCharlie Our team is looking at this issue (#558). Can you provide sources for these URLs? We're wanting to confirm on our end that they are indeed Facebook owned.

Thanks!

@maxxcrawford maxxcrawford added the default-domain Deals with default URLs assigned to the Facebook container label Dec 16, 2019
@ghost
Copy link
Author

ghost commented Dec 17, 2019

Ok, I am working on a list where you can verify each domain's ownership to Facebook.

@maxxcrawford
Copy link
Collaborator

@JesseCharlie Thank you! We're having an internal meeting tomorrow where we're discussing this list expansion. We really appreciate all the help. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
default-domain Deals with default URLs assigned to the Facebook container
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant