Only open prompt when user clicks badge #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxxcrawford
commented
Mar 14, 2022
| @@ -268,6 +270,14 @@ function shouldBadgeBeSmall(ratioCheck, itemHeight) { | |||
| return false; | |||
| } | |||
|
|
|||
| function openLoginPrompt(parent, el, htmlBadgeDiv) { | |||
There was a problem hiding this comment.
This change was required with the isTrusted checks. I moved this function outside of the addEventListener in-line event so that other functions could call it.
| @@ -652,7 +692,7 @@ async function detectFacebookOnPage () { | |||
|
|
|||
| // Check if user dismissed the Relay prompt | |||
| const relayAddonPromptDismissed = await getLocalStorageSettingFromBackground("hideRelayEmailBadges"); | |||
| if (!relayAddonEnabled && !relayAddonPromptDismissed.hideRelayEmailBadges && trackersDetectedOnCurrentPage) { | |||
| if (relayAddonPromptDismissed && !relayAddonEnabled && !relayAddonPromptDismissed.hideRelayEmailBadges && trackersDetectedOnCurrentPage) { | |||
There was a problem hiding this comment.
I kept getting console errors using this.
To check, visit airbnb.com. You should see an email prompt (if you do not have Relay installed and have not opt'ed out of the labels)
groovecoder
requested changes
Mar 14, 2022
Move prevent.default Co-authored-by: luke crouch <luke.crouch@gmail.com>
groovecoder
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves a few different items:
isTrustedfor any click eventsnpm audit)