Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove overriding CSS values from body #868

Merged
merged 2 commits into from
Sep 9, 2022
Merged

Conversation

codemist
Copy link
Collaborator

@codemist codemist commented Sep 8, 2022

This fixes the bug that overrode site CSS present in 2.3.3, which has now been replaced with 2.3.4 (repackaged 2.3.2).

@codemist codemist requested a review from groovecoder September 8, 2022 15:08
Copy link
Contributor

@lesleyjanenorton lesleyjanenorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's ship it! A micro-mitigation we might think about in the future is prefixing all of the CSS classes with fbc.

@s-weigand
Copy link

Thnx for the fix this broke my github dark theme ❤️

Another way to only apply the styles on the facebook page would be to use #facebook (id on the HTML tag) as the initial selector.

@groovecoder
Copy link
Member

Thanks @codemist for the quick fix and @lesleyjanenorton for the quick review! I re-opened #862 to see if we can fix it before we make the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants