Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't call set_notification_runloop #178

Open
wants to merge 1 commit into
base: trailblazer
Choose a base branch
from
Open

Don't call set_notification_runloop #178

wants to merge 1 commit into from

Conversation

ChunMinChang
Copy link
Member

@ChunMinChang ChunMinChang commented Sep 13, 2022 •
edited
Loading

To fix the issue mentioned in bug 1781964 comment 12 and, we should stop calling set_notification_runloop on Mac OS 10.7

@ChunMinChang
Copy link
Member Author

os_version relies on plist crate. I am considering using other method to get the os version without the dependencies so I won't need to audit plist in gecko.

@padenot
Copy link
Collaborator

padenot commented Sep 14, 2022

Yeah we don't care about super old macOS here, 10.7 is ancient.

@ChunMinChang ChunMinChang changed the title Don't call set_notification_runloop on Mac OS 10.7 or later version Don't call set_notification_runloop Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@padenot padenot Awaiting requested review from padenot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChunMinChang @padenot