Fix docs.rs build. #107
Closed
Fix docs.rs build. #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs.rs runs offline, so it cannot clone libcubeb. Therefore, do not exclude it from the package.
|
Alternatively, instead of this, we could just stub out libcubeb for the docs.rs build, since it is not necessary to build it for the documentation. |
|
As I think about it, I believe that that might be preferable. With the code here, we run the risk of producing a build without the rust backends. But, if we maintain existing behavior and just stub out the C bindings for docs.rs, we ensure that the rust bulids are always there, and also fix the docs.rs build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs.rs runs offline, so it cannot clone libcubeb. Therefore, do not exclude it from the package.